Bläddra i källkod

[spark] Log all caught naked "except:" blocks

Erick Tryzelaar 10 år sedan
förälder
incheckning
09321ff
2 ändrade filer med 6 tillägg och 2 borttagningar
  1. 5 1
      apps/spark/src/spark/conf.py
  2. 1 1
      apps/spark/src/spark/views.py

+ 5 - 1
apps/spark/src/spark/conf.py

@@ -16,6 +16,7 @@
 # limitations under the License.
 # limitations under the License.
 
 
 import json
 import json
+import logging
 import os
 import os
 import sys
 import sys
 
 
@@ -25,6 +26,9 @@ from desktop.lib.conf import Config, coerce_bool
 from spark.settings import NICE_NAME
 from spark.settings import NICE_NAME
 
 
 
 
+LOG = logging.getLogger(__name__)
+
+
 def coerce_json(j):
 def coerce_json(j):
   return json.loads(j)
   return json.loads(j)
 
 
@@ -89,7 +93,7 @@ def get_spark_status(user):
       get_api(user).get_status()
       get_api(user).get_status()
       status = 'OK'
       status = 'OK'
   except:
   except:
-    pass
+    LOG.exception('failed to get spark status')
 
 
   return status
   return status
 
 

+ 1 - 1
apps/spark/src/spark/views.py

@@ -49,7 +49,7 @@ def editor(request):
   try:
   try:
     autocomplete_base_url = reverse('beeswax:api_autocomplete_databases', kwargs={})
     autocomplete_base_url = reverse('beeswax:api_autocomplete_databases', kwargs={})
   except:
   except:
-    pass
+    LOG.exception('failed to get autocomplete base url')
 
 
   return render('editor.mako', request, {
   return render('editor.mako', request, {
       'notebooks_json': json.dumps([notebook.get_data()]),
       'notebooks_json': json.dumps([notebook.get_data()]),