Quellcode durchsuchen

HUE-8019 [assist] Make sure cached only catalog requests don't affect the non cached requests

The syntax checker only uses cached data and for such data catalog requests we shouldn't keep the promises around as it'll prevent subsequent requests to fail.
Johan Ahlen vor 7 Jahren
Ursprung
Commit
09d3f40
1 geänderte Dateien mit 4 neuen und 1 gelöschten Zeilen
  1. 4 1
      desktop/core/src/desktop/static/desktop/js/dataCatalog.js

+ 4 - 1
desktop/core/src/desktop/static/desktop/js/dataCatalog.js

@@ -714,6 +714,10 @@ var DataCatalog = (function () {
       }
       var deferred = $.Deferred();
 
+      if (options.cachedOnly && !self.sourceMeta && !self.sourceMetaPromise) {
+        return deferred.reject(false).promise();
+      }
+
       var sourceMetaPromise = self.getSourceMeta(options).done(function (sourceMeta) {
         if (!sourceMeta || sourceMeta.notFound) {
           deferred.reject();
@@ -1069,7 +1073,6 @@ var DataCatalog = (function () {
      * @param {string} comment
      * @param {Object} [apiOptions]
      * @param {boolean} [apiOptions.silenceErrors]
-     * @param {boolean} [apiOptions.cachedOnly]
      * @param {boolean} [apiOptions.refreshCache]
      *
      * @return {Promise}