Browse Source

HUE-1061 [useradmin] Edit group name

make group name non-readonly
Abraham Elmahrek 12 years ago
parent
commit
0efebd4f5d
2 changed files with 10 additions and 3 deletions
  1. 1 1
      apps/useradmin/src/useradmin/forms.py
  2. 9 2
      apps/useradmin/src/useradmin/tests.py

+ 1 - 1
apps/useradmin/src/useradmin/forms.py

@@ -193,7 +193,7 @@ class GroupEditForm(forms.ModelForm):
     super(GroupEditForm, self).__init__(*args, **kwargs)
 
     if self.instance.id:
-      self.fields['name'].widget.attrs['readonly'] = True
+      # self.fields['name'].widget.attrs['readonly'] = True
       initial_members = User.objects.filter(groups=self.instance).order_by('username')
       initial_perms = HuePermission.objects.filter(grouppermission__group=self.instance).order_by('app','description')
     else:

+ 9 - 2
apps/useradmin/src/useradmin/tests.py

@@ -271,11 +271,18 @@ def test_group_admin():
 
   # Should be one group left, because we created the other group
   response = c.post('/useradmin/groups/delete/testgroup')
-  assert_true(len(Group.objects.all()) == 1)
+  assert_equal(len(Group.objects.all()), 1)
 
   group_count = len(Group.objects.all())
   response = c.post('/useradmin/groups/new', dict(name="with space"))
-  assert_equal(len(Group.objects.all()), group_count + 1)
+  group_count += 1
+  assert_equal(len(Group.objects.all()), group_count)
+
+  # Rename a group
+  response = c.post('/useradmin/groups/edit/with space', dict(name='withspace'))
+  assert_equal(len(Group.objects.all()), group_count)
+  assert_equal(len(Group.objects.filter(name='withspace')), 1)
+  assert_equal(len(Group.objects.filter(name='with space')), 0)
 
 def test_user_admin():
   FUNNY_NAME = '~`!@#$%^&*()_-+={}[]|\;"<>?/,.'