Эх сурвалжийг харах

HUE-7069 [editor] Remove the spinner for risk checking

Johan Ahlen 8 жил өмнө
parent
commit
1e58534f91

+ 0 - 7
desktop/libs/notebook/src/notebook/static/notebook/js/notebook.ko.js

@@ -938,7 +938,6 @@ var EditorViewModel = (function() {
     self.suggestion = ko.observable('');
     self.hasSuggestion = ko.observable(null);
 
-    self.complexityCheckRunning = ko.observable(false);
     self.compatibilityCheckRunning = ko.observable(false);
     self.compatibilitySourcePlatform = ko.observable(self.type());
     self.compatibilitySourcePlatform.subscribe(function(newValue) {
@@ -993,7 +992,6 @@ var EditorViewModel = (function() {
         self.getApiHelper().cancelActiveRequest(lastComplexityRequest);
 
         hueAnalytics.log('notebook', 'get_query_risk');
-        self.complexityCheckRunning(true);
         self.hasSuggestion(null);
         self.complexity({});
         huePubSub.publish('editor.active.risks', {
@@ -1004,7 +1002,6 @@ var EditorViewModel = (function() {
         var changeSubscription = self.statement.subscribe(function () {
           changeSubscription.dispose();
           self.getApiHelper().cancelActiveRequest(lastComplexityRequest);
-          self.complexityCheckRunning(false);
         });
 
         lastComplexityRequest = $.ajax({
@@ -1031,10 +1028,6 @@ var EditorViewModel = (function() {
           },
           always: function(data) {
             changeSubscription.dispose();
-            self.complexityCheckRunning(false);
-          },
-          error: function(data) {
-            self.complexityCheckRunning(false);
           }
         });
 

+ 0 - 6
desktop/libs/notebook/src/notebook/templates/editor_components.mako

@@ -978,12 +978,6 @@ ${ sqlSyntaxDropdown.sqlSyntaxDropdown() }
 <script type="text/html" id="code-editor-snippet-body${ suffix }">
   <!-- ko if: HAS_OPTIMIZER && (type() == 'impala' || type() == 'hive') -->
   <div class="optimizer-container" data-bind="css: { 'active': showOptimizer }">
-    <!-- ko if: hasSuggestion() == null -->
-    <div class="round-icon idle" title="${ _ko('Checking statement for potential risks...') }">
-      <i class="fa" data-bind="css: {'fa-spinner fa-spin': complexityCheckRunning}"></i>
-    </div>
-    <!-- /ko -->
-
     <!-- ko if: hasSuggestion() -->
       <!-- ko with: suggestion() -->
         <!-- ko if: parseError -->