Browse Source

HUE-7982 [autocomplete] Give arrow key usage priority over mouse hover in the autocomplete suggestions list

Johan Ahlen 7 years ago
parent
commit
2d43613519

File diff suppressed because it is too large
+ 0 - 0
desktop/core/src/desktop/static/desktop/css/hue-embedded.css


File diff suppressed because it is too large
+ 0 - 0
desktop/core/src/desktop/static/desktop/css/hue.css


File diff suppressed because it is too large
+ 0 - 0
desktop/core/src/desktop/static/desktop/css/hue3-extra.css


+ 3 - 1
desktop/core/src/desktop/static/desktop/less/hue-autocomplete.less

@@ -112,7 +112,9 @@
   line-height: 18px;
   line-height: 18px;
 }
 }
 
 
-.autocompleter-suggestion:hover,
+.autocompleter-suggestion:hover {
+  background-color: @cui-blue-010;
+}
 .autocompleter-suggestion.selected {
 .autocompleter-suggestion.selected {
   background-color: @hue-primary-color-light;
   background-color: @hue-primary-color-light;
 }
 }

+ 6 - 0
desktop/core/src/desktop/templates/hue_ace_autocompleter.mako

@@ -406,9 +406,11 @@ from desktop.views import _ko
               self.editor().execCommand('golineup');
               self.editor().execCommand('golineup');
             } else if (self.selectedIndex() > 0) {
             } else if (self.selectedIndex() > 0) {
               self.selectedIndex(self.selectedIndex() - 1);
               self.selectedIndex(self.selectedIndex() - 1);
+              self.hoveredIndex(null);
               self.scrollSelectionIntoView();
               self.scrollSelectionIntoView();
             } else {
             } else {
               self.selectedIndex(self.suggestions.filtered().length - 1);
               self.selectedIndex(self.suggestions.filtered().length - 1);
+              self.hoveredIndex(null);
               self.scrollSelectionIntoView();
               self.scrollSelectionIntoView();
             }
             }
           },
           },
@@ -418,9 +420,11 @@ from desktop.views import _ko
               self.editor().execCommand('golinedown');
               self.editor().execCommand('golinedown');
             } else if (self.selectedIndex() < self.suggestions.filtered().length - 1) {
             } else if (self.selectedIndex() < self.suggestions.filtered().length - 1) {
               self.selectedIndex(self.selectedIndex() + 1);
               self.selectedIndex(self.selectedIndex() + 1);
+              self.hoveredIndex(null);
               self.scrollSelectionIntoView();
               self.scrollSelectionIntoView();
             } else {
             } else {
               self.selectedIndex(0);
               self.selectedIndex(0);
+              self.hoveredIndex(null);
               self.scrollSelectionIntoView();
               self.scrollSelectionIntoView();
             }
             }
           },
           },
@@ -430,6 +434,7 @@ from desktop.views import _ko
               self.editor().execCommand('gotostart');
               self.editor().execCommand('gotostart');
             } else {
             } else {
               self.selectedIndex(0);
               self.selectedIndex(0);
+              self.hoveredIndex(null);
               self.scrollSelectionIntoView();
               self.scrollSelectionIntoView();
             }
             }
           },
           },
@@ -439,6 +444,7 @@ from desktop.views import _ko
               self.editor().execCommand('gotoend');
               self.editor().execCommand('gotoend');
             } else if (self.suggestions.filtered().length > 0 ) {
             } else if (self.suggestions.filtered().length > 0 ) {
               self.selectedIndex(self.suggestions.filtered().length - 1);
               self.selectedIndex(self.suggestions.filtered().length - 1);
+              self.hoveredIndex(null);
               self.scrollSelectionIntoView();
               self.scrollSelectionIntoView();
             }
             }
           },
           },

Some files were not shown because too many files changed in this diff