Browse Source

[editor] Improved history UX

Enrico Berti 10 years ago
parent
commit
31d4d25

+ 1 - 1
desktop/libs/notebook/src/notebook/static/notebook/js/notebook.ko.js

@@ -984,7 +984,7 @@
             parsedHistory.push({
             parsedHistory.push({
               url: nbk.absoluteUrl,
               url: nbk.absoluteUrl,
               query: nbk.data.snippets[0].statement_raw,
               query: nbk.data.snippets[0].statement_raw,
-              lastExecuted: nbk.data.lastExecuted
+              lastExecuted: nbk.data.snippets[0].lastExecuted
             });
             });
           });
           });
         }
         }

+ 2 - 2
desktop/libs/notebook/src/notebook/templates/editor_components.mako

@@ -425,8 +425,8 @@ ${ require.config() }
           </tr>
           </tr>
         </thead>
         </thead>
         <tbody data-bind="foreach: $parent.history">
         <tbody data-bind="foreach: $parent.history">
-          <tr class="pointer" data-bind="click: function(){ location.href=url }">
-            <td><code data-bind="text: query"></code></td>
+          <tr class="pointer" data-bind="click: function(){ $parent.ace().setValue(query); history.pushState(null, null, url); $('.right-panel').animate({ scrollTop: '0px' }); }">
+            <td><code data-bind="text: query" style="white-space: normal"></code></td>
             <td style="width: 200px" class="muted"><span data-bind="text: moment(lastExecuted).format('LLL')"></span></td>
             <td style="width: 200px" class="muted"><span data-bind="text: moment(lastExecuted).format('LLL')"></span></td>
           </tr>
           </tr>
         </tbody>
         </tbody>