Browse Source

HUE-8831 [search] Support all SQL dialects in the dashboard autocomplete

Johan Ahlen 6 years ago
parent
commit
3359c5a5bc

+ 3 - 5
desktop/core/src/desktop/js/ko/components/simpleAceEditor/ko.simpleAceEditor.js

@@ -79,10 +79,6 @@ class SimpleAceEditor {
     self.ace(editor);
     self.ace(editor);
 
 
     if (params.autocomplete) {
     if (params.autocomplete) {
-      if (!AVAILABLE_AUTOCOMPLETERS[params.autocomplete.type]) {
-        throw new Error('Could not find autocompleter for "' + params.autocomplete.type + '"');
-      }
-
       const sourceType =
       const sourceType =
         params.autocomplete.type.indexOf('Query') !== -1
         params.autocomplete.type.indexOf('Query') !== -1
           ? params.autocomplete.type.replace('Query', '')
           ? params.autocomplete.type.replace('Query', '')
@@ -158,7 +154,9 @@ class SimpleAceEditor {
         support: params.autocomplete.support
         support: params.autocomplete.support
       };
       };
 
 
-      self.autocompleter = new AVAILABLE_AUTOCOMPLETERS[params.autocomplete.type](autocompleteArgs);
+      const AutocompleterClass =
+        AVAILABLE_AUTOCOMPLETERS[params.autocomplete.type] || SqlAutocompleter;
+      self.autocompleter = new AutocompleterClass(autocompleteArgs);
     } else {
     } else {
       self.autocompleter = null;
       self.autocompleter = null;
     }
     }