Explorar el Código

HUE-9211 [editor] Saving a query gets a popup exception saying 'dialect'

Romain hace 5 años
padre
commit
384692587b

+ 1 - 1
desktop/libs/notebook/src/notebook/api.py

@@ -447,7 +447,7 @@ def get_logs(request):
   return JsonResponse(response)
 
 def _save_notebook(notebook, user):
-  if notebook['snippets'][0].get('connector'):
+  if notebook['snippets'][0].get('connector') and notebook['snippets'][0]['connector'].get('dialect'):
     notebook_type = 'query-%(dialect)s' % notebook['snippets'][0]['connector']
   else:
     notebook_type = notebook.get('type', 'notebook')

+ 4 - 5
desktop/libs/notebook/src/notebook/api_tests.py

@@ -142,15 +142,14 @@ class TestApi(object):
 
 
   def test_save_notebook_with_connector(self):
-    if not ENABLE_CONNECTORS.get():
-      raise SkipTest
-
     notebook_cp = self.notebook.copy()
     notebook_cp.pop('id')
     notebook_cp['snippets'][0]['connector'] = {
-      "name": "MySql",
-      "dialect": "mysql"
+      "optimizer": "api"
     }
+    if not ENABLE_CONNECTORS.get():  # At some point even v1 should set those
+      notebook_cp['snippets'][0]['connector']['name'] = 'MySql'
+      notebook_cp['snippets'][0]['connector']['dialect'] = 'mysql'
     notebook_json = json.dumps(notebook_cp)
 
     response = self.client.post(reverse('notebook:save_notebook'), {'notebook': notebook_json})