Преглед изворни кода

HUE-7876 [presentation] Only hide right assist when toggling on

Romain Rigaux пре 7 година
родитељ
комит
3f02a89

+ 12 - 0
desktop/core/src/desktop/templates/hue.mako

@@ -1412,6 +1412,18 @@ ${ smart_unicode(login_modal(request).content) | n,unicode }
           }, 0);
         });
 
+        huePubSub.subscribe('side.panel.right.hide', function(withoutStorage){
+          previousVisibilityValues = {
+            left: self.leftAssistVisible(),
+            right: self.rightAssistVisible()
+          };
+          self.assistWithoutStorage(withoutStorage);
+          self.rightAssistVisible(false);
+          window.setTimeout(function(){
+            self.assistWithoutStorage(false);
+          }, 0);
+        });
+
         huePubSub.subscribe('side.panels.show', function(withoutStorage){
           self.assistWithoutStorage(withoutStorage);
           self.leftAssistVisible(previousVisibilityValues.left);

+ 8 - 1
desktop/libs/notebook/src/notebook/templates/editor_components.mako

@@ -3299,7 +3299,14 @@ ${ sqlSyntaxDropdown.sqlSyntaxDropdown() }
           wasLeftPanelVisible = viewModel.isLeftPanelVisible();
           console.log(viewModel.isPresentationMode());
           wasRightPanelVisible = viewModel.isRightPanelVisible();
-          //huePubSub.publish('side.panels.hide', true);
+          
+          if (wasResultFullScreenMode) {
+            huePubSub.publish('side.panels.hide', true);
+          } else {
+            huePubSub.publish('side.panel.right.hide', true);
+          }
+          
+          
           viewModel.assistWithoutStorage(true);
           viewModel.assistAvailable(false);
           viewModel.isLeftPanelVisible(true);