Explorar o código

HUE-8672 [jb] Protect against basic graph display when data is empty

Romain Rigaux %!s(int64=7) %!d(string=hai) anos
pai
achega
49011839c3

+ 2 - 2
desktop/core/src/desktop/static/desktop/js/apiHelper.js

@@ -991,8 +991,8 @@ var ApiHelper = (function () {
       type: 'POST',
       url: "/metadata/api/prometheus/query",
       data: {
-        "query": ko.mapping.toJSON("node_cpu_seconds_total"), // impala_queries
-        // TODO: labels
+        "query": ko.mapping.toJSON("impala_queries"),
+        // TODO: labels of cluster
         "start": ko.mapping.toJSON(start),
         "end": ko.mapping.toJSON(end),
         "step": ko.mapping.toJSON(step),

+ 6 - 2
desktop/core/src/desktop/templates/ko_components/ko_performance_graph.mako

@@ -142,7 +142,9 @@
 
 
         // Update scale domains from data
-        mainXScale.domain([self.data[0][0], self.data[self.data.length - 1][0]]);
+        if (self.data[0]) {
+          mainXScale.domain([self.data[0][0], self.data[self.data.length - 1][0]]);
+        }
         percentageYScale.domain([0, 100]);
         var queryMax = 15;
         self.data.forEach(function (row) {
@@ -433,10 +435,12 @@
                   mainGroup.select('.main-axis-x').call(mainXAxis);
                 });
 
-        subGroup.append('g')
+        if (self.data[0]) {
+          subGroup.append('g')
                 .attr('class', 'brush')
                 .call(brush)
                 .call(brush.move, [mainXScale(self.data[self.data.length - 1][0] - self.selectedGranularity().initialWindow), mainXScale(self.data[self.data.length - 1][0])]);
+        }
 
         // TODO: Custom handles