Эх сурвалжийг харах

HUE-6362 [frontend] Add more interpreter link should work and open

Romain Rigaux 8 жил өмнө
parent
commit
4a98588ad5

+ 12 - 8
desktop/core/src/desktop/templates/hue.mako

@@ -131,11 +131,18 @@ ${ hueIcons.symbols() }
           <!-- ko if: item.dividerAbove -->
           <!-- ko if: item.dividerAbove -->
           <li class="divider"></li>
           <li class="divider"></li>
           <!-- /ko -->
           <!-- /ko -->
-          <li data-bind="css: { 'dropdown-submenu': item.isCategory }"><a href="javascript: void(0);" data-bind="hueLink: item.url">
-            <!-- ko if: item.icon -->
-            <!-- ko template: { name: 'app-icon-template', data: item } --><!-- /ko -->
+          <li data-bind="css: { 'dropdown-submenu': item.isCategory }">
+            <!-- ko if: item.url -->
+             <a href="javascript: void(0);" data-bind="hueLink: item.url">
+                <!-- ko if: item.icon -->
+                <!-- ko template: { name: 'app-icon-template', data: item } --><!-- /ko -->
+                <!-- /ko -->
+                <span data-bind="css: { 'dropdown-no-icon': !item.icon }, text: item.displayName"></span>
+              </a>
+            <!-- /ko -->
+            <!-- ko if: item.href -->
+              <a data-bind="attr: { href: item.href }, text: item.displayName" target="_blank"></a>
             <!-- /ko -->
             <!-- /ko -->
-            <span data-bind="css: { 'dropdown-no-icon': !item.icon }, text: item.displayName"></span></a>
             <!-- ko if: item.isCategory -->
             <!-- ko if: item.isCategory -->
             <ul class="dropdown-menu" data-bind="foreach: { data: item.children, as: 'item' }">
             <ul class="dropdown-menu" data-bind="foreach: { data: item.children, as: 'item' }">
               <!-- ko template: 'quick-create-item-template' --><!-- /ko -->
               <!-- ko template: 'quick-create-item-template' --><!-- /ko -->
@@ -146,7 +153,6 @@ ${ hueIcons.symbols() }
       </div>
       </div>
 
 
 
 
-
       <div class="top-nav-middle">
       <div class="top-nav-middle">
         <div class="search-container-top">
         <div class="search-container-top">
           <input placeholder="${ _('Search data and saved documents...') }" type="text"
           <input placeholder="${ _('Search data and saved documents...') }" type="text"
@@ -1080,9 +1086,7 @@ ${ smart_unicode(login_modal(request).content) | n,unicode }
                   interpreters.push({
                   interpreters.push({
                     displayName: '${ _('Add more...') }',
                     displayName: '${ _('Add more...') }',
                     dividerAbove: true,
                     dividerAbove: true,
-                    click: function () {
-                      window.open('http://gethue.com/sql-editor/', '_blank');
-                    }
+                    href: 'http://gethue.com/sql-editor/'
                   });
                   });
                 }
                 }
               % endif
               % endif