Browse Source

HUE-8155 [assist] Prevent jumping description in the context popover

Johan Ahlen 7 years ago
parent
commit
4f57bad893

File diff suppressed because it is too large
+ 0 - 0
desktop/core/src/desktop/static/desktop/css/hue-embedded.css


File diff suppressed because it is too large
+ 0 - 0
desktop/core/src/desktop/static/desktop/css/hue.css


File diff suppressed because it is too large
+ 0 - 0
desktop/core/src/desktop/static/desktop/css/hue3-extra.css


+ 1 - 1
desktop/core/src/desktop/static/desktop/js/ko.hue-bindings.js

@@ -631,7 +631,7 @@
     MultiLineEllipsisHandler.prototype.refresh = function () {
     MultiLineEllipsisHandler.prototype.refresh = function () {
       var self = this;
       var self = this;
       self.$element.empty();
       self.$element.empty();
-      var  textElement = $('<span>').appendTo(self.$element)[0];
+      var textElement = $('<span>').appendTo(self.$element)[0];
       if (self.expandable) {
       if (self.expandable) {
         textElement.textContent = self.fullText;
         textElement.textContent = self.fullText;
         if (self.expanded || self.element.offsetHeight < self.element.scrollHeight || self.element.offsetWidth < self.element.scrollWidth) {
         if (self.expanded || self.element.offsetHeight < self.element.scrollHeight || self.element.offsetWidth < self.element.scrollWidth) {

+ 1 - 1
desktop/core/src/desktop/static/desktop/less/components/hue-popover.less

@@ -377,7 +377,7 @@
 }
 }
 
 
 .context-popover-comment {
 .context-popover-comment {
-  .flex(0 1 40px);
+  .flex(0 1 54px);
   margin-top: 2px;
   margin-top: 2px;
   margin-bottom: 8px;
   margin-bottom: 8px;
   padding-left: 4px;
   padding-left: 4px;

+ 1 - 2
desktop/core/src/desktop/templates/ko_components/ko_context_popover.mako

@@ -333,7 +333,7 @@ from metadata.conf import has_navigator
       <div class="context-popover-flex-fill" data-bind="with: catalogEntry, niceScroll">
       <div class="context-popover-flex-fill" data-bind="with: catalogEntry, niceScroll">
         <div class="context-popover-inner-content">
         <div class="context-popover-inner-content">
           <!-- ko if: $parent.comment() -->
           <!-- ko if: $parent.comment() -->
-          <div class="context-popover-comment" data-bind="attr: { 'title': $parent.comment }, multiLineEllipsis: $parent.commentOverflowing, style: { 'min-height': $parent.commentOverflowing() ? '40px' : null }, text: $parent.comment"></div>
+          <div class="context-popover-comment" data-bind="attr: { 'title': $parent.comment }, multiLineEllipsis, text: $parent.comment"></div>
           <!-- /ko -->
           <!-- /ko -->
 
 
           %if has_navigator(user):
           %if has_navigator(user):
@@ -410,7 +410,6 @@ from metadata.conf import has_navigator
 
 
         self.analysis = ko.observable();
         self.analysis = ko.observable();
         self.comment = ko.observable();
         self.comment = ko.observable();
-        self.commentOverflowing = ko.observable();
         self.viewSql = ko.observable();
         self.viewSql = ko.observable();
         self.viewSqlVisible = ko.observable(false);
         self.viewSqlVisible = ko.observable(false);
 
 

Some files were not shown because too many files changed in this diff