浏览代码

HUE-1296 [impala] Mock Impalad in the test cases

Romain Rigaux 12 年之前
父节点
当前提交
569602e74e
共有 1 个文件被更改,包括 15 次插入13 次删除
  1. 15 13
      apps/impala/src/impala/tests.py

+ 15 - 13
apps/impala/src/impala/tests.py

@@ -34,24 +34,26 @@ class MockDbms:
     return ['table1', 'table2']
 
 
-class TestImpala:
+class TestMockedImpala:
   def setUp(self):
     self.client = make_logged_in_client()
 
+    # Mock DB calls as we don't need the real ones
+    self.prev_dbms = dbms.get
+    dbms.get = lambda a, b: MockDbms()
+
+  def tearDown(self):
+    # Remove monkey patching
+    dbms.get = self.prev_dbms
+
   def test_basic_flow(self):
-    try:
-      # Mock DB calls as we don't need the real ones
-      self.prev_dbms = dbms.get
-      dbms.get = lambda a, b: MockDbms()
+    response = self.client.get("/impala/")
+    assert_true(re.search('<li id="impalaIcon"\W+class="active', response.content), response.content)
+    assert_true('Query Editor' in response.content)
 
-      response = self.client.get("/impala/")
-      assert_true(re.search('<li id="impalaIcon"\W+class="active', response.content), response.content)
-      assert_true('Query Editor' in response.content)
+    response = self.client.get("/impala/execute/")
+    assert_true('Query Editor' in response.content)
 
-      response = self.client.get("/impala/execute/")
-      assert_true('Query Editor' in response.content)
-    finally:
-      dbms.get = self.prev_dbms
 
   def test_saved_queries(self):
     user = User.objects.get(username='test')
@@ -90,7 +92,7 @@ def create_saved_query(app_name, owner):
     design = SavedQuery(owner=owner, type=query_type)
     design.name = SavedQuery.DEFAULT_NEW_DESIGN_NAME
     design.desc = ''
-    design.data = hql_query('show $tables').dumps()
+    design.data = hql_query('show $tables', database='db1').dumps()
     design.is_auto = False
     design.save()
     return design