Browse Source

[core] Use define instead of require for the assist panel and table stats

Johan Ahlen 10 years ago
parent
commit
5d5a2d2

+ 2 - 0
apps/metastore/src/metastore/templates/describe_table.mako

@@ -447,6 +447,8 @@ ${ assist.assistPanel() }
     "knockout",
     "ko.charts",
     "desktop/js/assist/assistHelper",
+    "assistPanel",
+    "tableStats",
     "knockout-mapping",
     "knockout-sortable",
     "knockout-deferred-updates",

+ 1 - 1
desktop/core/src/desktop/templates/assist.mako

@@ -273,7 +273,7 @@ from desktop.views import _ko
   <script type="text/javascript" charset="utf-8">
     (function (factory) {
       if(typeof require === "function") {
-        require(['knockout', 'desktop/js/assist/assistSource', 'desktop/js/assist/assistHelper'], factory);
+        define('assistPanel', ['knockout', 'desktop/js/assist/assistSource', 'desktop/js/assist/assistHelper', 'tableStats'], factory);
       } else {
         factory(ko, AssistSource, AssistHelper);
       }

+ 1 - 1
desktop/core/src/desktop/templates/table_stats.mako

@@ -101,7 +101,7 @@ from desktop.views import _ko
   <script type="text/javascript" charset="utf-8">
     (function (factory) {
       if(typeof require === "function") {
-        require(['knockout', 'desktop/js/assist/tableStats'], factory);
+        define("tableStats", ['knockout', 'desktop/js/assist/tableStats'], factory);
       } else {
         factory(ko, TableStats);
       }

+ 1 - 0
desktop/libs/notebook/src/notebook/templates/editor_components.mako

@@ -1525,6 +1525,7 @@ ${ require.config() }
     "knockout",
     "ko.charts",
     "notebook/js/notebook.ko",
+    "assistPanel",
     "knockout-mapping",
     "knockout-sortable",
     "knockout-deferred-updates",