Browse Source

HUE-8758 [connectors] Fix issue with loading back a snippet from history in editor v2

Johan Ahlen 5 years ago
parent
commit
5e61caebfb

+ 2 - 2
desktop/core/src/desktop/js/apps/notebook2/notebook.test.js

@@ -66,8 +66,8 @@ describe('notebook.js', () => {
     });
 
     const notebook = new Notebook(viewModel, {});
-    notebook.addSnippet({ connector: { dialect: 'hive' } });
-    notebook.addSnippet({ connector: { dialect: 'impala' } });
+    notebook.addSnippet({ connector: { dialect: 'hive', type: 'hive' } });
+    notebook.addSnippet({ connector: { dialect: 'impala', type: 'impala' } });
 
     expect(spy).toHaveBeenCalled();
 

+ 2 - 1
desktop/core/src/desktop/js/apps/notebook2/snippet.js

@@ -212,7 +212,8 @@ export default class Snippet {
           this.defaultLimit(this.editorConfig.default_limit);
         }
         const connectors = this.editorConfig.interpreters;
-        if (snippetRaw.connector) {
+
+        if (snippetRaw.connector && snippetRaw.connector.type) {
           this.connector(
             connectors.find(connector => connector.type === snippetRaw.connector.type) ||
               connectors.find(connector => connector.dialect === snippetRaw.connector.dialect)

+ 1 - 1
desktop/core/src/desktop/js/apps/notebook2/snippet.test.js

@@ -63,7 +63,7 @@ describe('snippet.js', () => {
     });
 
     const notebook = new Notebook(viewModel, {});
-    const snippet = notebook.addSnippet({ connector: { dialect: 'hive' } });
+    const snippet = notebook.addSnippet({ connector: { dialect: 'hive', type: 'hive' } });
 
     expect(spy).toHaveBeenCalled();