Эх сурвалжийг харах

[connector] Support connectors in Describe API

This API has an oddity on how to provide connectors for historical
reasons.

Fixing
AttributeError: 'Config' object has no attribute 'get'
Romain Rigaux 4 жил өмнө
parent
commit
5fe570dbef

+ 2 - 1
desktop/core/src/desktop/js/catalog/api.ts

@@ -143,7 +143,8 @@ export const fetchDescribe = ({
       {
         format: 'json',
         cluster: JSON.stringify(entry.compute),
-        source_type: entry.getConnector().id
+        source_type: entry.getConnector().id,
+        connector: JSON.stringify(entry.getConnector())
       },
       {
         silenceErrors,

+ 2 - 1
desktop/libs/notebook/src/notebook/api.py

@@ -1020,8 +1020,9 @@ def describe(request, database, table=None, column=None):
   response = {'status': -1, 'message': ''}
   notebook = json.loads(request.POST.get('notebook', '{}'))
   source_type = request.POST.get('source_type', '')
-  snippet = {'type': source_type}
+  connector = json.loads(request.POST.get('connector', '{}'))
 
+  snippet = {'type': source_type, 'connector': connector}
   patch_snippet_for_connector(snippet)
 
   describe = get_api(request, snippet).describe(notebook, snippet, database, table, column=column)