瀏覽代碼

HUE-9184 [editor] Fix js exception from the assist panel "open in editor" action

Johan Ahlen 5 年之前
父節點
當前提交
642e7ffcab

+ 2 - 2
desktop/core/src/desktop/js/apps/notebook/editorViewModel.js

@@ -576,7 +576,7 @@ class EditorViewModel {
                 self.changeURL(self.URLS.notebook + '?notebook=' + data.document.id);
               }
             }
-            if (typeof callback !== 'undefined') {
+            if (callback) {
               callback();
             }
             deferredOpen.resolve();
@@ -627,7 +627,7 @@ class EditorViewModel {
             });
           }
 
-          if (typeof callback !== 'undefined' && callback !== null) {
+          if (callback) {
             callback();
           }
         }

+ 2 - 2
desktop/core/src/desktop/js/apps/notebook2/editorViewModel.js

@@ -384,7 +384,7 @@ class EditorViewModel {
             });
           }
 
-          if (typeof callback !== 'undefined' && callback !== null) {
+          if (callback) {
             callback();
           }
           resolve();
@@ -422,7 +422,7 @@ class EditorViewModel {
           this.changeURL(this.URLS.notebook + '?notebook=' + docData.document.id);
         }
       }
-      if (typeof callback !== 'undefined') {
+      if (callback) {
         callback();
       }
     } catch (err) {