瀏覽代碼

[notebook] Notebooks with a lot of text are now more compact

Enrico Berti 10 年之前
父節點
當前提交
789229f06d

+ 13 - 0
desktop/libs/notebook/src/notebook/static/notebook/css/notebook.css

@@ -94,6 +94,18 @@ body {
   min-height: 40px;
 }
 
+.snippet-text .snippet-body {
+  min-height: 1px;
+}
+
+.snippet-text.card-widget {
+  min-height: 1px;
+}
+
+.snippet-body h2 {
+  padding-left: 0!important;
+}
+
 .snippet-settings {
   width: 200%;
   margin-left: -100%;
@@ -107,6 +119,7 @@ body {
   margin: 0;
   padding: 10px;
 }
+
 .snippet-settings-body {
   padding: 10px;
 }

+ 1 - 1
desktop/libs/notebook/src/notebook/static/notebook/js/notebook.ko.js

@@ -265,7 +265,7 @@ var Snippet = function (vm, notebook, snippet) {
     return self.status() == "loading";
   });
   self.klass = ko.computed(function () {
-    return "snippet card card-widget";
+    return "snippet card card-widget" + (self.type() == "text" ? " snippet-text" : "");
   });
 
   self.resultsKlass = ko.computed(function () {

+ 5 - 2
desktop/libs/notebook/src/notebook/templates/editor_components.mako

@@ -332,7 +332,7 @@ from desktop.views import _ko
 
       <h5 class="card-heading-print" data-bind="text: name, css: {'visible': name() != ''}"></h5>
 
-      <h2 class="card-heading simple">
+      <h2 class="card-heading simple" data-bind="visible: type() != 'text' || $root.isEditing()">
 
         <div class="dropdown inline widget-type" data-bind="visible: type() != 'text' || $root.isEditing()">
           <a class="dropdown-toggle no-underline" data-toggle="dropdown" href="javascript:void(0)">
@@ -982,7 +982,7 @@ from desktop.views import _ko
               var loaded = JSON.parse(e.target.result);
 
               if (loaded.cells) { //ipython
-                loaded.cells.forEach(function (cell) {
+                loaded.cells.forEach(function (cell, cellCnt) {
                   window.setTimeout(function () {
                     if (cell.cell_type == "code") {
                       addPySpark(cell.source.join("\n"));
@@ -990,6 +990,9 @@ from desktop.views import _ko
                     if (cell.cell_type == "markdown") {
                       addMarkdown(cell.source.join("\n"));
                     }
+                    if (cellCnt == loaded.cells.length - 1 && aceChecks == 0){
+                      hideHoverMsg();
+                    }
                   }, 10);
                 });
               }