Browse Source

HUE-5304 [notebook] Do not 500 on query upload from notebook

Notebook does not have any query id, so skip the upload
Romain Rigaux 8 years ago
parent
commit
7bdd083
1 changed files with 2 additions and 3 deletions
  1. 2 3
      desktop/libs/metadata/src/metadata/optimizer_api.py

+ 2 - 3
desktop/libs/metadata/src/metadata/optimizer_api.py

@@ -358,10 +358,9 @@ def upload_query(request):
   response = {'status': -1}
 
   source_platform = request.POST.get('sourcePlatform', 'default')
+  query_id = request.POST.get('query_id')
 
-  if OPTIMIZER.AUTO_UPLOAD_QUERIES.get() and source_platform in ('hive', 'impala'):
-    query_id = request.POST.get('query_id')
-
+  if OPTIMIZER.AUTO_UPLOAD_QUERIES.get() and source_platform in ('hive', 'impala') and query_id:
     doc = Document2.objects.document(request.user, doc_id=query_id)
 
     query_data = Notebook(document=doc).get_data()