Browse Source

[assist] Silence errors from the HDFS autocompleter and show the correct details from errors in the assist

Johan Ahlen 10 years ago
parent
commit
90a52e3

+ 10 - 6
desktop/core/src/desktop/static/desktop/js/assist/assistHelper.js

@@ -126,12 +126,16 @@
   AssistHelper.prototype.assistErrorCallback = function (options) {
     return function (errorResponse) {
       var errorMessage = 'Unknown error occurred';
-      if (typeof errorResponse !== 'undefined' && typeof errorResponse.message !== 'undefined') {
-        errorMessage = errorResponse.message;
-      } else if (typeof errorResponse !== 'undefined' && typeof errorResponse.statusText !== 'undefined') {
-        errorMessage = errorResponse.statusText;
-      } else if (typeof errorResponse !== 'undefined' && toString.call(errorResponse) == '[object String]') {
-        errorMessage = errorResponse;
+      if (errorResponse !== 'undefined') {
+        if (typeof errorResponse.message !== 'undefined') {
+          errorMessage = errorResponse.message;
+        } else if (typeof errorResponse.statusText !== 'undefined') {
+          errorMessage = errorResponse.statusText;
+        } else if (errorResponse.error !== 'undefined' && toString.call(errorResponse.error) === '[object String]' ) {
+          errorMessage = errorResponse.error;
+        } else if (toString.call(errorResponse) === '[object String]') {
+          errorMessage = errorResponse;
+        }
       }
 
       if (! options.silenceErrors) {

+ 1 - 0
desktop/core/src/desktop/static/desktop/js/hdfsAutocompleter.js

@@ -98,6 +98,7 @@
       self.snippet.getAssistHelper().fetchHdfsPath({
         pathParts: parts,
         successCallback: successCallback,
+        silenceErrors: true,
         errorCallback: onFailure,
         editor: editor
       });