소스 검색

[desktop] Don't create models in a default argument

Previously, this would create a groupname when the test_utils
module was imported. Something changed in the import ordering,
which caused this file to be included before the test database
was setup. This raised an exception.
Erick Tryzelaar 10 년 전
부모
커밋
94cf67d
1개의 변경된 파일4개의 추가작업 그리고 1개의 파일을 삭제
  1. 4 1
      desktop/core/src/desktop/lib/test_utils.py

+ 4 - 1
desktop/core/src/desktop/lib/test_utils.py

@@ -38,7 +38,10 @@ def add_permission(username, groupname, permname, appname):
         user.save()
 
 
-def add_to_group(username, groupname=get_default_user_group().name):
+def add_to_group(username, groupname=None):
+    if groupname is None:
+        groupname = get_default_user_group().name
+
     user = User.objects.get(username=username)
     group, created = Group.objects.get_or_create(name=groupname)