Bladeren bron

HUE-9445 [phoenix] Listing table sample in Table Browser errors

Romain 5 jaren geleden
bovenliggende
commit
96aba14cf3

+ 1 - 1
desktop/core/src/desktop/lib/connectors/types.py

@@ -231,7 +231,7 @@ CONNECTOR_TYPES = [
     'description': '',
     'properties': {
       'is_sql': True,
-      'sql_identifier_quote': '`',
+      'sql_identifier_quote': '"',
       'sql_identifier_comment_single': '--',
       'has_catalog': False,
       'has_database': False,

+ 1 - 1
desktop/libs/notebook/src/notebook/connectors/sql_alchemy.py

@@ -124,7 +124,7 @@ class SqlAlchemyApi(Api):
     if interpreter.get('dialect_properties'):
       self.backticks = interpreter['dialect_properties']['sql_identifier_quote']
     else:
-      self.backticks = '"' if re.match('^(postgresql://|awsathena|elasticsearch)', self.options.get('url', '')) else '`'
+      self.backticks = '"' if re.match('^(postgresql://|awsathena|elasticsearch|phoenix)', self.options.get('url', '')) else '`'
 
   def _get_engine(self):
     engine_key = ENGINE_KEY % {

+ 2 - 2
desktop/libs/notebook/src/notebook/connectors/sql_alchemy_tests.py

@@ -303,13 +303,13 @@ class TestDialects(object):
 
 
   def test_backticks_without_connectors(self):
-    interpreter = {'name': 'hive', 'options': {'url': 'phoenix://'}}
+    interpreter = {'name': 'hive', 'options': {'url': 'hive://'}}
     data = SqlAlchemyApi(self.user, interpreter).get_browse_query(snippet=Mock(), database='db1', table='table1')
 
     assert_equal(data, 'SELECT *\nFROM `db1`.`table1`\nLIMIT 1000\n')
 
 
-    interpreter = {'name': 'hive', 'options': {'url': 'postgresql://'}}
+    interpreter = {'name': 'postgresql', 'options': {'url': 'postgresql://'}}
     data = SqlAlchemyApi(self.user, interpreter).get_browse_query(snippet=Mock(), database='db1', table='table1')
 
     assert_equal(data, 'SELECT *\nFROM "db1"."table1"\nLIMIT 1000\n')