Pārlūkot izejas kodu

[useradmin] Log all caught naked "except:" blocks

Erick Tryzelaar 10 gadi atpakaļ
vecāks
revīzija
9c840705fd

+ 6 - 3
apps/useradmin/src/useradmin/ldap_access.py

@@ -127,14 +127,17 @@ class LdapConnection(object):
       try:
         self.ldap_handle.simple_bind_s(bind_user, bind_password)
       except:
-        raise RuntimeError("Failed to bind to LDAP server as user %s" %
-            bind_user)
+        msg = "Failed to bind to LDAP server as user %s" % bind_user
+        LOG.exception(msg)
+        raise RuntimeError(msg)
     else:
       try:
         # Do anonymous bind
         self.ldap_handle.simple_bind_s('','')
       except:
-        raise RuntimeError("Failed to bind to LDAP server anonymously")
+        msg = "Failed to bind to LDAP server anonymously"
+        LOG.exception(msg)
+        raise RuntimeError(msg)
 
   def _get_search_params(self, name, attr, find_by_dn=False):
     """

+ 2 - 1
apps/useradmin/src/useradmin/models.py

@@ -163,7 +163,7 @@ def create_profile_for_user(user):
     p.save()
     return p
   except:
-    LOG.debug("Failed to automatically create user profile.", exc_info=True)
+    LOG.exception("Failed to automatically create user profile.")
     return None
 
 class LdapGroup(models.Model):
@@ -236,6 +236,7 @@ def update_app_permissions(**kwargs):
       for dp in HuePermission.objects.all():
         current.setdefault(dp.app, {})[dp.action] = dp
     except:
+      LOG.exception('failed to get permissions')
       return
 
     updated = 0