瀏覽代碼

[compute][ui] old saved queries failing to load

This fix adds a check to avoid
`Uncaught TypeError: Cannot read properties of undefined (reading 'dialect')`
Amit Srivastava 8 月之前
父節點
當前提交
9f9a4f1ec6
共有 2 個文件被更改,包括 2 次插入2 次删除
  1. 1 1
      desktop/core/src/desktop/js/apps/notebook/snippet.js
  2. 1 1
      desktop/core/src/desktop/js/parse/utils.ts

+ 1 - 1
desktop/core/src/desktop/js/apps/notebook/snippet.js

@@ -217,7 +217,7 @@ class Snippet {
       return vm.getSnippetViewSettings(self.dialect()).sqlDialect;
     });
 
-    self.dialect = ko.pureComputed(() => this.connector().dialect);
+    self.dialect = ko.pureComputed(() => this.connector() && this.connector().dialect);
 
     self.isBatchable = ko.computed(() => {
       return (

+ 1 - 1
desktop/core/src/desktop/js/parse/utils.ts

@@ -20,7 +20,7 @@ import sqlStatementsParser from 'parse/sqlStatementsParser';
 import { SqlStatementsParser } from './types';
 
 export const getStatementsParser = (connector: Connector): SqlStatementsParser => {
-  if (connector.dialect === 'hplsql') {
+  if (connector && connector.dialect === 'hplsql') {
     return hplsqlStatementsParser as unknown as SqlStatementsParser;
   } else {
     return sqlStatementsParser;