Sfoglia il codice sorgente

HUE-9212 [core] Fix missing login-modal causes auto logout failed

Ying Chen 5 anni fa
parent
commit
a037d0746d

+ 1 - 1
desktop/core/src/desktop/auth/views.py

@@ -186,7 +186,7 @@ def dt_login(request, from_modal=False):
         ensure_home_directory(request.fs, request.user)
       except (IOError, WebHdfsException) as e:
         LOG.error('Could not create home directory for %s user %s.' % ('OIDC' if 'OIDCBackend' in backend_names else 'SAML', request.user))
-    if request.user.is_authenticated():
+    if request.user.is_authenticated() and not from_modal:
       return HttpResponseRedirect(redirect_to)
 
   if is_active_directory and not is_ldap_option_selected and \

+ 5 - 0
desktop/core/src/desktop/auth/views_test.py

@@ -729,6 +729,11 @@ class TestLogin(PseudoHdfsTestBase):
     response = client.post('/hue/accounts/login/', dict(username=self.test_username, password="test"), follow=True)
     assert_equal(200, response.status_code, "Expected unauthorized status.")
 
+  def test_modal_login(self):
+    c = make_logged_in_client(username='test', password='test', is_superuser=False, recreate=True)
+    response = c.get('/hue')
+    assert_true(b'<div id="login-modal" class="modal fade hide">' in response.content, response.content)
+
 
 class TestLoginNoHadoop(object):