浏览代码

fixes the lint errors

Ram Prasad Agarwal 8 月之前
父节点
当前提交
abde24e892

+ 14 - 21
desktop/core/src/desktop/js/reactComponents/FileUploadQueue/FileUploadQueue.tsx

@@ -49,7 +49,6 @@ const FileUploadQueue: React.FC<FileUploadQueueProps> = ({ filesQueue, onClose,
     !!config?.hue_config.enable_task_server;
 
   const { t } = i18nReact.useTranslation();
-  const [isExpanded, setIsExpanded] = useState(true);
 
   const { uploadQueue, onCancel } = useFileUpload(filesQueue, {
     isChunkUpload,
@@ -62,12 +61,8 @@ const FileUploadQueue: React.FC<FileUploadQueueProps> = ({ filesQueue, onClose,
   ).length;
 
   return (
-    <div className="upload-queue cuix antd">
-      <div
-        className="upload-queue__header"
-        data-testid="upload-queue__header"
-        onClick={() => setIsExpanded(prev => !prev)}
-      >
+    <details className="upload-queue cuix antd" open>
+      <summary className="upload-queue__header" data-testid="upload-queue__header">
         {pendingCount > 0
           ? t('{{count}} file(s) remaining', {
               count: pendingCount
@@ -76,21 +71,19 @@ const FileUploadQueue: React.FC<FileUploadQueueProps> = ({ filesQueue, onClose,
               count: uploadedCount
             })}
         <CloseIcon onClick={onClose} height={16} width={16} />
+      </summary>
+      <div className="upload-queue__list">
+        {uploadQueue
+          .sort((a, b) => sortOrder[a.status] - sortOrder[b.status])
+          .map((row: RegularFile) => (
+            <FileUploadRow
+              key={`${row.filePath}__${row.file.name}`}
+              data={row}
+              onCancel={() => onCancel(row)}
+            />
+          ))}
       </div>
-      {isExpanded && (
-        <div className="upload-queue__list">
-          {uploadQueue
-            .sort((a, b) => sortOrder[a.status] - sortOrder[b.status])
-            .map((row: RegularFile) => (
-              <FileUploadRow
-                key={`${row.filePath}__${row.file.name}`}
-                data={row}
-                onCancel={() => onCancel(row)}
-              />
-            ))}
-        </div>
-      )}
-    </div>
+    </details>
   );
 };
 

+ 2 - 2
desktop/core/src/desktop/js/reactComponents/FileUploadQueue/FileUploadRow/FileUploadRow.test.tsx

@@ -58,8 +58,8 @@ describe('FileUploadRow', () => {
 
   it('should show progress bar when file is in uploading state', () => {
     const mockData = { ...mockUploadRow, status: FileStatus.Uploading, progress: 10 };
-    const { getByRole } = render(<FileUploadRow data={mockData} onCancel={mockOnCancel} />);
-    const progressBar = getByRole('hue-upload-queue-row__progressbar');
+    const { getByTestId } = render(<FileUploadRow data={mockData} onCancel={mockOnCancel} />);
+    const progressBar = getByTestId('hue-upload-queue-row__progressbar');
     expect(progressBar).toBeInTheDocument();
     expect(progressBar).toHaveStyle('width: 10%');
   });

+ 1 - 1
desktop/core/src/desktop/js/reactComponents/FileUploadQueue/FileUploadRow/FileUploadRow.tsx

@@ -59,7 +59,7 @@ const FileUploadRow: React.FC<FileUploadRowProps> = ({ data, onCancel }) => {
       </div>
       <div
         className="hue-upload-queue-row__progressbar"
-        role="hue-upload-queue-row__progressbar"
+        data-testid="hue-upload-queue-row__progressbar"
         style={{
           width: `${data.status === FileStatus.Uploading ? data.progress : 0}%`
         }}

+ 0 - 2
desktop/core/src/desktop/js/reactComponents/PathBrowser/PathBrowser.tsx

@@ -105,7 +105,6 @@ const PathBrowser = ({
               onFilepathChange((event.target as HTMLInputElement).value);
             }}
             className="hue-path-browser__input"
-            autoFocus
             data-testid={`${testId}-input`}
           />
         </div>
@@ -165,7 +164,6 @@ const PathBrowser = ({
                   className: 'hue-path-browser__dropdown-menu'
                 }}
                 trigger={['hover', 'click']}
-                autoFocus
                 data-testid={`${testId}-dropdown`}
               >
                 <BorderlessButton