瀏覽代碼

[ci][ruff] Switch to new custom Ruff cmd for python linting in CI checks (#3723)

Harsh Gupta 1 年之前
父節點
當前提交
c1875deb9d

+ 1 - 1
.circleci/config.yml

@@ -54,7 +54,7 @@ commands:
       - run:
           name: run python lints
           command: |
-            ./tools/ci/check_for_python_lint.sh
+            PYTHONWARNINGS=always ./build/env/bin/hue runruff check
 
       - run:
           name: run tests

+ 1 - 1
.github/workflows/commitflow-py3.yml

@@ -60,7 +60,7 @@ jobs:
 
     - name: run python lints
       run: |
-        ./tools/ci/check_for_python_lint.sh
+        PYTHONWARNINGS=always ./build/env/bin/hue runruff check
 
     - name: run documentation lints
       run: |

+ 0 - 5
desktop/core/src/desktop/management/commands/runruff.py

@@ -119,11 +119,6 @@ class Command(BaseCommand):
 
     ruff_cmd = [ruff_package] + options.get('ruff_args')
 
-    # Exit with a status code of 0 even if linting violations were found and only fail for actual error
-    # Skip adding when running ruff format command
-    if not any(arg in ruff_cmd for arg in ["--exit-zero", "format"]):
-      ruff_cmd.append("--exit-zero")
-
     if options.get('diff_branch'):
       diff_files = self.diff_files(options['diff_branch'])
 

+ 0 - 43
tools/ci/check_for_python_lint.sh

@@ -1,43 +0,0 @@
-#!/usr/bin/env bash
-# Licensed to Cloudera, Inc. under one
-# or more contributor license agreements.  See the NOTICE file
-# distributed with this work for additional information
-# regarding copyright ownership.  Cloudera, Inc. licenses this file
-# to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance
-# with the License.  You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-
-# Checking all python changes in the new commits
-
-HOME=${1:-"."}
-FOUND_ISSUE=-1
-
-files=`git diff --name-only origin/master --diff-filter=bd | egrep .py$` 
-
-cd $HOME
-
-if [ ! -z "$files" ];
-then
-  ./build/env/bin/ruff check $files
-  FOUND_ISSUE=$?
-else
-  echo "No Python code files changes present."
-  FOUND_ISSUE=0
-fi
-
-if [ "$FOUND_ISSUE" -eq "0" ]
-then
-  echo "No Python code styling issues found."
-else
-  echo "Found some Python code styling issues."
-fi
-
-exit $FOUND_ISSUE