소스 검색

HUE-9678 [Django Upgrade] Direct assignment to the forward side of a many-to-many set is deprecated due to the implicit save() that happens

ayush.goyal 4 년 전
부모
커밋
cf75f7c9ed
2개의 변경된 파일7개의 추가작업 그리고 9개의 파일을 삭제
  1. 1 1
      apps/oozie/src/oozie/models2.py
  2. 6 8
      desktop/core/src/desktop/models.py

+ 1 - 1
apps/oozie/src/oozie/models2.py

@@ -3779,7 +3779,7 @@ def _save_workflow(workflow, layout, user, fs=None):
     Document.objects.link(workflow_doc, owner=workflow_doc.owner, name=workflow_doc.name, description=workflow_doc.description, extra='workflow2')
 
   # Excludes all the sub-workflow and Hive dependencies. Contains list of history and coordinator dependencies.
-  workflow_doc.dependencies = workflow_doc.dependencies.exclude(Q(is_history=False) & Q(type__in=['oozie-workflow2', 'query-hive', 'query-java']))
+  workflow_doc.dependencies.set(workflow_doc.dependencies.exclude(Q(is_history=False) & Q(type__in=['oozie-workflow2', 'query-hive', 'query-java'])))
 
   dependencies = \
       [node['properties']['workflow'] for node in workflow['nodes'] if node['type'] == 'subworkflow-widget'] + \

+ 6 - 8
desktop/core/src/desktop/models.py

@@ -880,13 +880,11 @@ class DocumentPermissionManager(models.Manager):
     perm, created = DocumentPermission.objects.get_or_create(doc=document, perms=name)
 
     if users is not None:
-      perm.users = []
-      perm.users = users
+      perm.users.set(users)
       perm.save()
 
     if groups is not None:
-      perm.groups = []
-      perm.groups = groups
+      perm.groups.set(groups)
       perm.save()
 
     if not users and not groups:
@@ -1481,13 +1479,13 @@ class Document2(models.Model):
 
     perm, created = Document2Permission.objects.get_or_create(doc=self, perms=name)
 
-    perm.users = []
+    perm.users.clear()
     if users is not None:
-      perm.users = users
+      perm.users.set(users)
 
-    perm.groups = []
+    perm.groups.clear()
     if groups is not None:
-      perm.groups = groups
+      perm.groups.set(groups)
 
     perm.is_link_on = is_link_on