Răsfoiți Sursa

HUE-6639 [assist] Fix issue where drop-downs are hidden behind flex panels in Hue 3

Johan Ahlen 8 ani în urmă
părinte
comite
ddb6089

Fișier diff suprimat deoarece este prea mare
+ 0 - 0
desktop/core/src/desktop/static/desktop/css/hue.css


Fișier diff suprimat deoarece este prea mare
+ 0 - 0
desktop/core/src/desktop/static/desktop/css/hue3-extra.css


+ 8 - 0
desktop/core/src/desktop/static/desktop/less/hue-cross-version.less

@@ -405,6 +405,14 @@ ul.errorlist {
 .hue-drop-down-container {
   position: fixed;
   z-index: 900;
+
+  &.open {
+    position: absolute;
+  }
+
+  &.hue-drop-down-fixed {
+    position: fixed !important;
+  }
 }
 
 .hue-drop-down-active span {

+ 2 - 2
desktop/core/src/desktop/templates/assist.mako

@@ -513,7 +513,7 @@ from notebook.conf import get_ordered_interpreters
   <script type="text/html" id="assist-document-header-actions">
     <div class="assist-db-header-actions">
       <!-- ko if: !loading() && availableTypeFilters().length > 1 -->
-      <div data-bind="component: { name: 'hue-drop-down', params: { value: typeFilter, entries: availableTypeFilters, linkTitle: '${ _ko('Document type') }' } }" style="display: inline-block"></div>
+      <div data-bind="component: { name: 'hue-drop-down', params: { fixedPosition: true, value: typeFilter, entries: availableTypeFilters, linkTitle: '${ _ko('Document type') }' } }" style="display: inline-block"></div>
       <!-- /ko -->
       <a class="inactive-action" href="javascript:void(0)" data-bind="visible: !loading(), toggle: isFilterVisible, css: { 'blue': isFilterVisible }" title="Filter"><i class="pointer fa fa-filter"></i></a>
       <a class="inactive-action" href="javascript:void(0)" data-bind="click: function () { huePubSub.publish('assist.file.refresh'); }"><i class="pointer fa fa-refresh" data-bind="css: { 'fa-spin blue' : loading }" title="${_('Manual refresh')}"></i></a>
@@ -1651,7 +1651,7 @@ from notebook.conf import get_ordered_interpreters
       <div class="assist-flex-panel">
         <div class="assist-flex-header">
           <div class="assist-inner-header">
-            <div class="function-dialect-dropdown" data-bind="component: { name: 'hue-drop-down', params: { value: activeType, entries: availableTypes, linkTitle: '${ _ko('Selected dialect') }' } }" style="display: inline-block"></div>
+            <div class="function-dialect-dropdown" data-bind="component: { name: 'hue-drop-down', params: { fixedPosition: true, value: activeType, entries: availableTypes, linkTitle: '${ _ko('Selected dialect') }' } }" style="display: inline-block"></div>
             <div class="assist-db-header-actions" style="margin-right:10px;">
               <a class="inactive-action" href="javascript:void(0)" data-bind="click: function () { searchVisible(!searchVisible()); query(''); }, css: { 'blue' : searchVisible }"><i class="pointer fa fa-filter" title="${ _('Filter') }"></i></a>
             </div>

+ 2 - 1
desktop/core/src/desktop/templates/ko_components.mako

@@ -37,7 +37,7 @@ from desktop.views import _ko
     <input class="hue-drop-down-input" type="text" data-bind="textInput: filter, attr: { 'placeHolder': value }, visible: dropDownVisible, style: { color: filterEdited() ? '#000' : '#AAA', 'min-height': '22px', 'margin-left': '10px' }"/>
     <i class="fa fa-caret-down"></i>
     <!-- /ko -->
-    <div class="hue-drop-down-container" data-bind="css: { 'open' : dropDownVisible }">
+    <div class="hue-drop-down-container" data-bind="css: { 'open' : dropDownVisible, 'hue-drop-down-fixed': fixedPosition }">
       <div class="dropdown-menu" data-bind="visible: filteredEntries().length > 0" style="overflow-y: scroll; width: 190px; margin-left: 10px; min-height: 34px; max-height: 200px;">
         <!-- ko if: foreachVisible -->
         <ul class="hue-inner-drop-down" data-bind="foreachVisible: { data: filteredEntries, minHeight: 34, container: '.dropdown-menu' }">
@@ -64,6 +64,7 @@ from desktop.views import _ko
         self.searchable = params.searchable || false;
         self.foreachVisible = params.foreachVisible || false;
         self.linkTitle = params.linkTitle || '${ _('Selected entry') }';
+        self.fixedPosition = !!params.fixedPosition;
 
         var closeOnOutsideClick = function (e) {
           var $input = $(element).find('.hue-drop-down-input');

Fișier diff suprimat deoarece este prea mare
+ 0 - 0
desktop/libs/notebook/src/notebook/static/notebook/css/notebook.css


+ 0 - 8
desktop/libs/notebook/src/notebook/static/notebook/less/notebook.less

@@ -1291,12 +1291,4 @@
   .query-name {
     margin-left: 28px;
   }
-
-  .hue-drop-down-container {
-   position: fixed;
-    z-index: 900;
-    &.open {
-      position: absolute;
-    }
-  }
 }

Unele fișiere nu au fost afișate deoarece prea multe fișiere au fost modificate în acest diff