فهرست منبع

HUE-9066 [frontend] Improve gist sharing layout

Johan Ahlen 6 سال پیش
والد
کامیت
ecba66299e

+ 1 - 1
desktop/core/src/desktop/js/apps/notebook2/components/ko.snippetEditorActions.js

@@ -46,7 +46,7 @@ const TEMPLATE = `
         <a href="javascript:void(0)" data-bind="click: createGist, css: { 'disabled': !createGistEnabled() }" title="${I18n(
           'Share the query selection via a link'
         )}">
-          <i class="fa fa-wf fa-link"></i> ${I18n('Share as gist')}
+          <i class="fa fa-fw fa-link"></i> ${I18n('Get shareable link')}
         </a>
       </li>
       <!-- /ko -->

+ 3 - 7
desktop/core/src/desktop/js/ko/components/__snapshots__/ko.shareGistModal.test.js.snap

@@ -12,15 +12,11 @@ exports[`ko.shareGistModal.js should render component 1`] = `
         <form autocomplete=\\"off\\">
           <input id=\\"gistLink\\" class=\\"input-xxlarge\\" autocorrect=\\"off\\" autocomplete=\\"do-not-autocomplete\\" autocapitalize=\\"off\\" spellcheck=\\"false\\" onfocus=\\"this.select()\\" data-bind=\\"value: link\\" type=\\"text\\" placeholder=\\"Link\\">
         </form>
-        <div class=\\"input-prepend\\">
-          <a class=\\"btn gist-link-btn\\" data-clipboard-target=\\"#gistLink\\" data-bind=\\"clipboard\\" data-dismiss=\\"modal\\">Copy</a>
-          <button class=\\"add-on muted gist-link-btn\\" data-clipboard-target=\\"#gistLink\\" data-bind=\\"clipboard\\">
-            <i class=\\"fa fa-clipboard\\"></i>
-          </button>
-        </div>
+        <button class=\\"btn\\" type=\\"button\\" data-dismiss=\\"modal\\" data-clipboard-target=\\"#gistLink\\" data-bind=\\"clipboard\\">
+          <i class=\\"fa fa-clipboard\\"></i> Copy
+        </button>
       </div>
     </div>
-
   </div>
   <div class=\\"modal-footer\\">
     <a class=\\"btn\\" data-dismiss=\\"modal\\">Close</a>

+ 3 - 7
desktop/core/src/desktop/js/ko/components/ko.shareGistModal.js

@@ -36,15 +36,11 @@ const TEMPLATE = `
         <form autocomplete="off">
           <input id="gistLink" class="input-xxlarge" ${ window.PREVENT_AUTOFILL_INPUT_ATTRS } onfocus="this.select()" data-bind="value: link" type="text" placeholder="${ I18n('Link') }"/>
         </form>
-        <div class="input-prepend">
-          <a class="btn gist-link-btn" data-clipboard-target="#gistLink" data-bind="clipboard" data-dismiss="modal">${ I18n('Copy') }</a>
-          <button class="add-on muted gist-link-btn" data-clipboard-target="#gistLink" data-bind="clipboard" >
-            <i class="fa fa-clipboard"></i>
-          </button>
-        </div>
+        <button class="btn" type="button" data-dismiss="modal" data-clipboard-target="#gistLink" data-bind="clipboard">
+          <i class="fa fa-clipboard"></i> ${ I18n('Copy') }
+        </button>
       </div>
     </div>
-
   </div>
   <div class="modal-footer">
     <a class="btn" data-dismiss="modal">${ I18n('Close') }</a>

+ 1 - 1
desktop/libs/notebook/src/notebook/templates/editor_components.mako

@@ -1796,7 +1796,7 @@ ${ sqlSyntaxDropdown.sqlSyntaxDropdown() }
         % if conf.ENABLE_GIST.get():
         <li>
           <a href="javascript:void(0)" data-bind="click: createGist, css: {'disabled': ! isReady() }" title="${ _('Share the query selection via a link') }">
-            <i class="fa fa-fw fa-link"></i> ${_('Share as a gist')}
+            <i class="fa fa-fw fa-link"></i> ${_('Get shareable link')}
           </a>
         </li>
         % endif