Bläddra i källkod

HUE-4116 [oozie] Cleaner way to refresh the parameters of a workflow in a coordinator

Romain Rigaux 9 år sedan
förälder
incheckning
f238dff5
1 ändrade filer med 25 tillägg och 25 borttagningar
  1. 25 25
      apps/oozie/src/oozie/static/oozie/js/coordinator-editor.ko.js

+ 25 - 25
apps/oozie/src/oozie/static/oozie/js/coordinator-editor.ko.js

@@ -88,35 +88,35 @@ var Coordinator = function (vm, coordinator) {
   }
 
   self.refreshParameters = function() {
-    self.properties.workflow.valueHasMutated();
+    $.get("/oozie/editor/workflow/parameters/", {
+      "uuid": self.properties.workflow(),
+    }, function (data) {
+      self.workflowParameters(data.parameters);
+
+      // Remove Uncommon params
+      prev_variables = self.variables.slice();
+      $.each(prev_variables, function (index, variable) {
+        if (data.parameters.filter(function(param) { return param['name'] == variable.workflow_variable() }).length == 0) {
+          self.variables.remove(variable);
+        }
+      });
+
+      // Append the new variables
+      prev_variables = self.variables.slice();
+      $.each(data.parameters, function (index, param) {
+        if (prev_variables.filter(function(variable) { return param['name'] == variable.workflow_variable() }).length == 0) {
+          self.addVariable();
+          self.variables()[self.variables().length - 1].workflow_variable(param['name']);
+        }
+      });
+    }).fail(function (xhr, textStatus, errorThrown) {
+      $(document).trigger("error", xhr.responseText);
+    });
   }
 
   self.properties.workflow.subscribe(function (newVal) {
     if (newVal) {
-      $.get("/oozie/editor/workflow/parameters/", {
-        "uuid": self.properties.workflow(),
-      }, function (data) {
-        self.workflowParameters(data.parameters);
-
-        // Remove Uncommon params
-        prev_variables = self.variables.slice();
-        $.each(prev_variables, function (index, variable) {
-          if (data.parameters.filter(function(param) { return param['name'] == variable.workflow_variable() }).length == 0) {
-            self.variables.remove(variable);
-          }
-        });
-
-        // Append the new variables
-        prev_variables = self.variables.slice();
-        $.each(data.parameters, function (index, param) {
-          if (prev_variables.filter(function(variable) { return param['name'] == variable.workflow_variable() }).length == 0) {
-            self.addVariable();
-            self.variables()[self.variables().length - 1].workflow_variable(param['name']);
-          }
-        });
-      }).fail(function (xhr, textStatus, errorThrown) {
-        $(document).trigger("error", xhr.responseText);
-      });
+      self.refreshParameters();
     }
   });