Forráskód Böngészése

HUE-8758 [beeswax] Avoid KeyError on install examples

KeyError: 'request'
Romain 5 éve
szülő
commit
fd07dc2986

+ 2 - 3
apps/beeswax/src/beeswax/views.py

@@ -15,8 +15,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-from builtins import next
-from builtins import str
+from builtins import next, str
 import json
 import logging
 import re
@@ -617,7 +616,7 @@ def install_examples(request):
         dialect = 'hive'
       db_name = request.POST.get('db_name', 'default')
       connector_id = request.POST.get('connector_id')
-      beeswax_install_examples.Command().handle(dialect=dialect, db_name=db_name, user=request.user)
+      beeswax_install_examples.Command().handle(dialect=dialect, db_name=db_name, user=request.user, request=request)
       response['status'] = 0
     except Exception as err:
       LOG.exception(err)

+ 57 - 0
apps/beeswax/src/beeswax/views_tests.py

@@ -0,0 +1,57 @@
+#!/usr/bin/env python
+# -*- coding: utf-8 -*-
+# Licensed to Cloudera, Inc. under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  Cloudera, Inc. licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+import logging
+import json
+import sys
+
+from django.urls import reverse
+from nose.tools import assert_equal, assert_not_equal, assert_true, assert_false
+
+from desktop.lib.django_test_util import make_logged_in_client
+from useradmin.models import User
+
+if sys.version_info[0] > 2:
+  from unittest.mock import patch, Mock, MagicMock
+else:
+  from mock import patch, Mock, MagicMock
+
+
+LOG = logging.getLogger(__name__)
+
+
+class TestInstallExamples():
+
+  def setUp(self):
+    self.client = make_logged_in_client(username="test", groupname="default", recreate=True, is_superuser=True, is_admin=True)
+    self.user = User.objects.get(username="test")
+
+
+  def test_install_via_insert_mysql(self):
+
+    with patch('beeswax.views.beeswax_install_examples.SampleTable') as SampleTable:
+      with patch('beeswax.views.beeswax_install_examples.SampleQuery') as SampleQuery:
+
+        resp = self.client.post(reverse('beeswax:install_examples'), {'db_name': 'default'})
+        data = json.loads(resp.content)
+
+        assert_equal(0, data['status'], data)
+        assert_equal('', data['message'], data)
+
+        SampleTable.assert_called()
+        SampleQuery.assert_called()