Преглед изворни кода

HUE-5530 [responsive] Remove multiple bindings on the same element

Enrico Berti пре 9 година
родитељ
комит
fd62d08

+ 2 - 2
desktop/libs/notebook/src/notebook/templates/editor_components.mako

@@ -2450,7 +2450,7 @@ ${ hueIcons.symbols() }
 </%def>
 
 
-<%def name="commonJS(is_embeddable=False)">
+<%def name="commonJS(is_embeddable=False, bindableElement='editorComponents')">
 
 <script type="text/javascript" charset="utf-8">
   % if is_embeddable:
@@ -3573,7 +3573,7 @@ ${ hueIcons.symbols() }
       % else:
       viewModel = new EditorViewModel(${ editor_id or 'null' }, ${ notebooks_json | n,unicode }, VIEW_MODEL_OPTIONS);
       % endif
-      ko.applyBindings(viewModel, $('.editorComponents')[0]);
+      ko.applyBindings(viewModel, $('#${ bindableElement }')[0]);
       viewModel.init();
 
       if (location.getParameter("github_status") != "") {

+ 2 - 2
desktop/libs/notebook/src/notebook/templates/notebook.mako

@@ -26,7 +26,7 @@
 
 ${ commonheader(_('Notebook'), app_name, user, request, "68px") | n,unicode }
 
-<span class="notebook">
+<span id="notebookComponents" class="notebook">
 ${ editorComponents.includes() }
 ${ editorComponents.topBar() }
 <%editorComponents:commonHTML>
@@ -54,7 +54,7 @@ ${ configKoComponents.config() }
 ${ notebookKoComponents.addSnippetMenu() }
 ${ notebookKoComponents.downloadSnippetResults() }
 
-${ editorComponents.commonJS() }
+${ editorComponents.commonJS(bindableElement='notebookComponents') }
 
 </span>
 ${ commonfooter(request, messages) | n,unicode }

+ 1 - 1
desktop/libs/notebook/src/notebook/templates/notebook_embeddable.mako

@@ -50,6 +50,6 @@ ${ configKoComponents.config() }
 ${ notebookKoComponents.addSnippetMenu() }
 ${ notebookKoComponents.downloadSnippetResults() }
 
-${ editorComponents.commonJS(is_embeddable=True) }
+${ editorComponents.commonJS(is_embeddable=True, bindableElement='notebookComponents') }
 
 </span>